IBX-8471: Upgraded codebase to Symfony 7 (#66)

* [Composer] Bumped 3rd party packages compatible with for Symfony 7
* IBX-9811: Upgraded metrics queries to doctrine/dbal v3
* IBX-9811: Adapted RepositorySystemInfoCollector to doctrine/dbal v3
* [Tests] Adapted
\Ibexa\Tests\Bundle\SystemInfo\SystemInfo\Collector\RepositorySystemInfoCollectorTest::testCollect
* [Tests] Updated tests/bundle/SystemInfo/Collector/RepositorySystemInfoCollectorTest.php

---------

Co-authored-by: Adam Wójs <[email protected]>
Co-authored-by: Dawid Parafiński <[email protected]>
Co-authored-by: Konrad Oboza <[email protected]>

Author: 4 people

composer.json

@@ -28,7 +28,7 @@
         "ibexa/search": "~5.0.x-dev",
         "ibexa/test-core": "~5.0.x-dev",
         "ibexa/user": "~5.0.x-dev",
-        "matthiasnoback/symfony-dependency-injection-test": "^4.0",
+        "matthiasnoback/symfony-dependency-injection-test": "^5.0",
         "phpstan/phpstan": "^2.0",
         "phpstan/phpstan-phpunit": "^2.0",
         "phpstan/phpstan-symfony": "^2.0",

phpstan.neon

@@ -10,6 +10,3 @@ parameters:
         - src
         - tests
     treatPhpDocTypesAsCertain: false
-    ignoreErrors:
-        -
-            message: "#^Cannot call method (fetchOne|fetchColumn|fetchAllAssociative|fetchAssociative|fetchAllKeyValue|fetchFirstColumn)\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"

src/bundle/SystemInfo/Collector/RepositorySystemInfoCollector.php

@@ -45,11 +45,13 @@ public function __construct(Connection $db, MetricsProvider $metricsProvider)
      */
     public function collect(): RepositorySystemInfo
     {
+        $params = $this->connection->getParams();
+
         return new RepositorySystemInfo([
             'type' => $this->connection->getDatabasePlatform()->getName(),
             'name' => $this->connection->getDatabase(),
-            'host' => $this->connection->getHost(),
-            'username' => $this->connection->getUsername(),
+            'host' => $params['host'] ?? '',
+            'username' => $params['user'] ?? '',
             'repositoryMetrics' => $this->populateRepositoryMetricsData(),
         ]);
     }

src/lib/Storage/Metrics/ContentTypesCountMetrics.php

@@ -32,6 +32,6 @@ public function getValue(): int
                 $queryBuilder->expr()->eq(self::VERSION_COLUMN, Type::STATUS_DEFINED)
             );
 
-        return (int) $queryBuilder->execute()->fetchColumn();
+        return (int) $queryBuilder->executeQuery()->fetchFirstColumn();
     }
 }

src/lib/Storage/Metrics/DraftsCountMetrics.php

@@ -44,6 +44,6 @@ public function getValue(): int
             )
             ->setParameter('status', ContentInfo::STATUS_DRAFT, ParameterType::INTEGER);
 
-        return (int) $queryBuilder->execute()->fetchColumn();
+        return (int) $queryBuilder->executeQuery()->fetchFirstColumn();
     }
 }

src/lib/Storage/Metrics/PublishedContentObjectsCountMetrics.php

@@ -32,6 +32,6 @@ public function getValue(): int
                 $queryBuilder->expr()->eq(self::STATUS_COLUMN, ContentInfo::STATUS_PUBLISHED)
             );
 
-        return (int) $queryBuilder->execute()->fetchColumn();
+        return (int) $queryBuilder->executeQuery()->fetchFirstColumn();
     }
 }

src/lib/Storage/Metrics/UsersCountMetrics.php

@@ -26,6 +26,6 @@ public function getValue(): int
             ->select($this->getCountExpression(self::CONTENTOBJECT_ID_COLUMN))
             ->from(self::USER_TABLE);
 
-        return (int) $queryBuilder->execute()->fetchColumn();
+        return (int) $queryBuilder->executeQuery()->fetchFirstColumn();
     }
 }

src/lib/Storage/Metrics/VersionsCountMetrics.php

@@ -26,6 +26,6 @@ public function getValue(): int
             ->select($this->getCountExpression(self::ID_COLUMN))
             ->from(self::CONTENTOBJECT_VERSION_TABLE);
 
-        return (int) $queryBuilder->execute()->fetchColumn();
+        return (int) $queryBuilder->executeQuery()->fetchFirstColumn();
     }
 }

tests/bundle/SystemInfo/Collector/RepositorySystemInfoCollectorTest.php

@@ -64,27 +64,25 @@ public function testCollect(): void
         $this->dbalConnectionMock
             ->expects(self::once())
             ->method('getDatabasePlatform')
-            ->will(self::returnValue($this->dbalPlatformMock));
+            ->willReturn($this->dbalPlatformMock);
 
         $this->dbalPlatformMock
             ->expects(self::once())
             ->method('getName')
-            ->will(self::returnValue($expected->type));
+            ->willReturn($expected->type);
 
         $this->dbalConnectionMock
             ->expects(self::once())
             ->method('getDatabase')
-            ->will(self::returnValue($expected->name));
+            ->willReturn($expected->name);
 
         $this->dbalConnectionMock
             ->expects(self::once())
-            ->method('getHost')
-            ->will(self::returnValue($expected->host));
-
-        $this->dbalConnectionMock
-            ->expects(self::once())
-            ->method('getUsername')
-            ->will(self::returnValue($expected->username));
+            ->method('getParams')
+            ->willReturn([
+                'host' => $expected->host,
+                'user' => $expected->username,
+            ]);
 
         $this->metricsProviderMock
             ->expects(self::exactly(5))