IBX-8174: Applied review remarks

barw4 · barw4 · commit b5d64cee7c43 · 2024-07-17T13:35:53.000+02:00
diff --git a/src/lib/Server/Input/Parser/RestoreTrashItemInput.php b/src/lib/Server/Input/Parser/RestoreTrashItemInput.php
@@ -15,6 +15,7 @@
 use Ibexa\Rest\Server\Exceptions\ValidationFailedException;
 use Ibexa\Rest\Server\Validation\Builder\Input\Parser\RestoreTrashItemInputValidatorBuilder;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
+use Webmozart\Assert\Assert;
 
 final class RestoreTrashItemInput extends BaseParser
 {
@@ -59,7 +60,11 @@ private function extractLocationIdFromPath(string $path): int
     {
         $pathParts = explode('/', $path);
 
-        return (int)array_pop($pathParts);
+        $lastPart = array_pop($pathParts);
+
+        Assert::integerish($lastPart);
+
+        return (int)$lastPart;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`use Ibexa\Rest\Server\Exceptions\ValidationFailedException;`
`16`	`16`	`use Ibexa\Rest\Server\Validation\Builder\Input\Parser\RestoreTrashItemInputValidatorBuilder;`
`17`	`17`	`use Symfony\Component\Validator\Validator\ValidatorInterface;`
	`18`	`+use Webmozart\Assert\Assert;`
`18`	`19`
`19`	`20`	`final class RestoreTrashItemInput extends BaseParser`
`20`	`21`	`{`
`@@ -59,7 +60,11 @@ private function extractLocationIdFromPath(string $path): int`
`59`	`60`	`{`
`60`	`61`	`$pathParts = explode('/', $path);`
`61`	`62`
`62`		`- return (int)array_pop($pathParts);`
	`63`	`+ $lastPart = array_pop($pathParts);`
	`64`	`+`
	`65`	`+ Assert::integerish($lastPart);`
	`66`	`+`
	`67`	`+ return (int)$lastPart;`
`63`	`68`	`}`
`64`	`69`
`65`	`70`	`/**`