IBX-9727: Aligned library code with PHP8+ and added missing strict types (#1697)

Author: konradoboza

phpstan-baseline.neon

@@ -469,8 +469,8 @@ public function updateAction(
             '@ibexadesign/content_type/edit.html.twig',
             $group,
             $contentTypeDraft,
-            $baseLanguage ?? $language,
-            $form
+            $form,
+            $baseLanguage ?? $language
         );
         $view->addParameters([
             'field_type_toolbar' => $this->fieldTypeToolbarFactory->create(),
@@ -667,15 +667,15 @@ public function createUpdateForm(
                 'contentTypeGroupId' => $contentTypeGroup->id,
                 'contentTypeId' => $contentTypeDraft->id,
                 'fromLanguageCode' => $baseLanguage?->getLanguageCode(),
-                'toLanguageCode' => $language->getLanguageCode(),
+                'toLanguageCode' => $language?->getLanguageCode(),
             ]),
-            'languageCode' => $language->getLanguageCode(),
+            'languageCode' => $language?->getLanguageCode(),
             'mainLanguageCode' => $contentTypeDraft->mainLanguageCode,
         ]);
     }
 
     /**
-     * @return FormInterface<mixed>
+     * @return \Symfony\Component\Form\FormInterface<mixed>
      */
     protected function createDeleteForm(ContentTypeGroup $group, ContentType $contentType): FormInterface
     {

src/bundle/Controller/ContentTypeController.php

@@ -225,7 +225,7 @@ private function createContentEditForm(
         ?Language $language = null,
         ?Location $location = null
     ): FormInterface {
-        $languageCodes = $versionInfo->getLanguageCodes() ?? [];
+        $languageCodes = $versionInfo === null ? [] : $versionInfo->getLanguageCodes();
 
         return $this->formFactory->contentEdit(
             new ContentEditData($contentInfo, null, $language, $location),

src/bundle/Controller/ContentViewController.php

@@ -12,7 +12,7 @@ services:
 
     Ibexa\AdminUi\Siteaccess\SiteaccessResolver:
         arguments:
-            $siteaccessPreviewVoters: !tagged_iterator ibexa.admin_ui.site_access.preview.voter
+            $siteAccessPreviewVoters: !tagged_iterator ibexa.admin_ui.site_access.preview.voter
             $siteAccessService: '@Ibexa\Core\MVC\Symfony\SiteAccess\SiteAccessService'
 
     Ibexa\AdminUi\Siteaccess\NonAdminSiteaccessResolver:

src/bundle/Resources/config/services/siteaccess.yaml

@@ -7,8 +7,8 @@
         {% set body_row_cols = [] %}
 
         {% set col_raw %}
-            <a href="{{ path('ibexa.role.view', { roleId: policy.role_assignment.role.id}) }}">
-                {{ policy.role_assignment.role.identifier }}
+            <a href="{{ path('ibexa.role.view', { roleId: policy.roleAssignment.role.id}) }}">
+                {{ policy.roleAssignment.role.identifier }}
             </a>
         {% endset %}
         {% set body_row_cols = body_row_cols|merge([{
@@ -17,10 +17,10 @@
         }]) %}
 
         {% set col_raw %}
-            {%- if policy.role_assignment.usergroup is defined -%}
-                {{ ibexa_content_name( policy.role_assignment.usergroup ) }}
+            {%- if policy.roleAssignment.usergroup is defined -%}
+                {{ ibexa_content_name( policy.roleAssignment.usergroup ) }}
             {%- else -%}
-                {{ ibexa_content_name( policy.role_assignment.user ) }}
+                {{ ibexa_content_name( policy.roleAssignment.user ) }}
             {%- endif -%}
         {% endset %}
         {% set body_row_cols = body_row_cols|merge([{

src/bundle/Resources/views/themes/admin/content/tab/policies/tab.html.twig

@@ -14,6 +14,8 @@ interface PermissionCheckerInterface
 {
     /**
      * @param array<mixed> $hasAccess
+     *
+     * @return array<mixed>
      */
     public function getRestrictions(array $hasAccess, string $class): array;
 

src/contracts/Permission/PermissionCheckerInterface.php

@@ -18,7 +18,7 @@
 
 final class DraftListActionMenuBuilder extends AbstractActionBuilder implements TranslationContainerInterface
 {
-    public const ITEM_EDIT_DRAFT = 'draft_list__action__content_edit';
+    public const string ITEM_EDIT_DRAFT = 'draft_list__action__content_edit';
 
     protected function getConfigureEventName(): string
     {

src/lib/Menu/Action/DraftListActionMenuBuilder.php

@@ -18,10 +18,10 @@
 
 final class VersionListActionMenuBuilder extends AbstractActionBuilder implements TranslationContainerInterface
 {
-    public const ITEM_EDIT_DRAFT = 'version_list__action__content_edit';
-    public const ITEM_RESTORE_VERSION = 'version_list__action__restore_version';
+    public const string ITEM_EDIT_DRAFT = 'version_list__action__content_edit';
+    public const string ITEM_RESTORE_VERSION = 'version_list__action__restore_version';
 
-    private const ICON_ARCHIVE_RESTORE = 'archive-restore';
+    private const string ICON_ARCHIVE_RESTORE = 'archive-restore';
 
     protected function getConfigureEventName(): string
     {

src/lib/Menu/Action/VersionListActionMenuBuilder.php

@@ -4,6 +4,7 @@
  * @copyright Copyright (C) Ibexa AS. All rights reserved.
  * @license For full copyright and license information view LICENSE file distributed with this source code.
  */
+declare(strict_types=1);
 
 namespace Ibexa\AdminUi\Menu\Admin\ContentType;
 
@@ -16,12 +17,11 @@
  *
  * @see https://symfony.com/doc/current/bundles/KnpMenuBundle/menu_builder_service.html
  */
-class ContentTypeCreateRightSidebarBuilder extends AbstractContentTypeRightSidebarBuilder implements TranslationContainerInterface
+final class ContentTypeCreateRightSidebarBuilder extends AbstractContentTypeRightSidebarBuilder implements TranslationContainerInterface
 {
-    /* Menu items */
-    public const ITEM__SAVE = 'content_type_create__sidebar_right__save';
-    public const ITEM__PUBLISH_AND_EDIT = 'content_type_create__sidebar_right__publish_and_edit';
-    public const ITEM__CANCEL = 'content_type_create__sidebar_right__cancel';
+    public const string ITEM__SAVE = 'content_type_create__sidebar_right__save';
+    public const string ITEM__PUBLISH_AND_EDIT = 'content_type_create__sidebar_right__publish_and_edit';
+    public const string ITEM__CANCEL = 'content_type_create__sidebar_right__cancel';
 
     protected function getConfigureEventName(): string
     {

src/lib/Menu/Admin/ContentType/ContentTypeCreateRightSidebarBuilder.php

@@ -4,6 +4,7 @@
  * @copyright Copyright (C) Ibexa AS. All rights reserved.
  * @license For full copyright and license information view LICENSE file distributed with this source code.
  */
+declare(strict_types=1);
 
 namespace Ibexa\AdminUi\Menu\Admin\ContentType;
 
@@ -16,12 +17,11 @@
  *
  * @see https://symfony.com/doc/current/bundles/KnpMenuBundle/menu_builder_service.html
  */
-class ContentTypeEditRightSidebarBuilder extends AbstractContentTypeRightSidebarBuilder implements TranslationContainerInterface
+final class ContentTypeEditRightSidebarBuilder extends AbstractContentTypeRightSidebarBuilder implements TranslationContainerInterface
 {
-    /* Menu items */
-    public const ITEM__SAVE = 'content_type_edit__sidebar_right__save';
-    public const ITEM__PUBLISH_AND_EDIT = 'content_type_edit__sidebar_right__publish_and_edit';
-    public const ITEM__CANCEL = 'content_type_edit__sidebar_right__cancel';
+    public const string ITEM__SAVE = 'content_type_edit__sidebar_right__save';
+    public const string ITEM__PUBLISH_AND_EDIT = 'content_type_edit__sidebar_right__publish_and_edit';
+    public const string ITEM__CANCEL = 'content_type_edit__sidebar_right__cancel';
 
     protected function getConfigureEventName(): string
     {