Skip to content

Commit 3b9617e

Browse files
authored
IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore (#1373)
1 parent b793c7b commit 3b9617e

File tree

9 files changed

+55
-43
lines changed

9 files changed

+55
-43
lines changed

package.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,15 @@
55
"prettier": "eslint-config-ibexa/prettier",
66
"dependencies": {},
77
"devDependencies": {
8-
"eslint-config-ibexa": "https://github.com/ibexa/eslint-config-ibexa.git#~v1.1.1"
8+
"eslint-config-ibexa": "https://github.com/ibexa/eslint-config-ibexa.git#~v1.2.0",
9+
"@ibexa/ts-config": "https://github.com/ibexa/ts-config-ibexa#~v1.0.0",
10+
"@types/react": "^18.3.11",
11+
"@types/react-dom": "^18.3.1"
912
},
1013
"scripts": {
1114
"test": "yarn prettier-test && yarn eslint-test",
1215
"fix": "yarn prettier-test --write && yarn eslint-test --fix",
13-
"eslint-test": "eslint \"./src/bundle/Resources/**/*.js\" \"./src/bundle/ui-dev/**/*.js\"",
14-
"prettier-test": "yarn prettier \"./src/bundle/Resources/**/*.{js,scss}\" \"./src/bundle/ui-dev/**/*.js\" --check"
16+
"eslint-test": "eslint \"./src/bundle/Resources/**/*.{js,ts}\" \"./src/bundle/ui-dev/**/*.{js,tsx}\"",
17+
"prettier-test": "yarn prettier \"./src/bundle/Resources/**/*.{js,ts,scss}\" \"./src/bundle/ui-dev/**/*.{js,tsx}\" --check"
1518
}
1619
}

src/bundle/Resources/encore/ibexa.config.setup.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ const path = require('path');
33
module.exports = (Encore) => {
44
Encore.addAliases({
55
'@ibexa-admin-ui': path.resolve('./vendor/ibexa/admin-ui'),
6+
'@ibexa-admin-ui-helpers': path.resolve('./vendor/ibexa/admin-ui/src/bundle/Resources/public/js/scripts/helpers'),
67
'@ibexa-admin-ui-modules': path.resolve('./vendor/ibexa/admin-ui/src/bundle/ui-dev/src/modules'),
78
});
89
};

src/bundle/Resources/encore/ibexa.js.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ module.exports = (Encore) => {
129129
path.resolve(__dirname, '../public/js/scripts/button.content.edit.js'),
130130
path.resolve(__dirname, '../public/js/scripts/admin.search.filters.js'),
131131
path.resolve(__dirname, '../public/js/scripts/admin.search.sorting.js'),
132-
path.resolve(__dirname, '../public/js/scripts/admin.search.js'),
132+
path.resolve(__dirname, '../public/ts/admin.search.ts'),
133133
path.resolve(__dirname, '../public/js/scripts/udw/select.location.js'),
134134
path.resolve(__dirname, '../public/js/scripts/button.translation.edit.js'),
135135
])

src/bundle/Resources/public/js/scripts/admin.search.js

Lines changed: 0 additions & 21 deletions
This file was deleted.
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
(function () {
2+
const searchForm = document.querySelector<HTMLFormElement>('.ibexa-search-form');
3+
const searchInput = document.querySelector<HTMLInputElement>('.ibexa-search-form__search-input');
4+
const headerSearchInput = document.querySelector<HTMLInputElement>('.ibexa-global-search__input');
5+
const languageSelector = document.querySelector<HTMLSelectElement>('.ibexa-filters__item--language-selector .ibexa-filters__select');
6+
const headerSearchSubmitBtn = document.querySelector<HTMLButtonElement>(
7+
'.ibexa-main-header .ibexa-input-text-wrapper__action-btn--search',
8+
);
9+
10+
if (!headerSearchInput || !searchInput || !searchForm) {
11+
return;
12+
}
13+
14+
const submitForm = () => {
15+
searchInput.value = headerSearchInput.value;
16+
searchForm.submit();
17+
};
18+
const handleHeaderSearchBtnClick = (event: MouseEvent) => {
19+
event.preventDefault();
20+
21+
submitForm();
22+
};
23+
24+
headerSearchInput.value = searchInput.value;
25+
26+
headerSearchSubmitBtn?.addEventListener('click', handleHeaderSearchBtnClick, false);
27+
languageSelector?.addEventListener('change', submitForm, false);
28+
})();

src/bundle/ui-dev/src/modules/common/thumbnail/thumbnail.js renamed to src/bundle/ui-dev/src/modules/common/thumbnail/thumbnail.tsx

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import React from 'react';
2-
import PropTypes from 'prop-types';
3-
42
import Icon from '../icon/icon';
3+
import ThumbnailProps from './thumbnail.types';
54

6-
const Thumbnail = ({ thumbnailData, iconExtraClasses, contentTypeIconPath }) => {
7-
const renderContentTypeIcon = () => {
5+
const Thumbnail = ({ thumbnailData, iconExtraClasses, contentTypeIconPath }: ThumbnailProps) => {
6+
const renderContentTypeIcon = (): React.JSX.Element | null => {
87
if (!contentTypeIconPath) {
98
return null;
109
}
@@ -32,18 +31,4 @@ const Thumbnail = ({ thumbnailData, iconExtraClasses, contentTypeIconPath }) =>
3231
);
3332
};
3433

35-
Thumbnail.propTypes = {
36-
thumbnailData: PropTypes.shape({
37-
mimeType: PropTypes.string.isRequired,
38-
resource: PropTypes.string.isRequired,
39-
}).isRequired,
40-
iconExtraClasses: PropTypes.string,
41-
contentTypeIconPath: PropTypes.string,
42-
};
43-
44-
Thumbnail.defaultProps = {
45-
iconExtraClasses: null,
46-
contentTypeIconPath: null,
47-
};
48-
4934
export default Thumbnail;
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import { ThumbnailData } from '../types/common';
2+
3+
export default interface ThumbnailProps extends ThumbnailData {
4+
iconExtraClasses?: string;
5+
contentTypeIconPath?: string;
6+
};
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
export interface ThumbnailData {
2+
thumbnailData: {
3+
mimeType: string;
4+
resource: string;
5+
}
6+
}

tsconfig.eslint.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"extends": "@ibexa/ts-config",
3+
"include": ["src/bundle/**/*"]
4+
}

0 commit comments

Comments
 (0)