@VincentLanglet Personally I am fine throwing a something like an InvalidArgumentException or LogicException (after a major version bump because of the BC break) in case the method is called with a country not supported by this library. That would help keep the API a bit cleaner. What are your thoughts on that?

@VincentLanglet Personally I am fine throwing a something like an InvalidArgumentException or LogicException (after a major version bump because of the BC break) in case the method is called with a country not supported by this library. That would help keep the API a bit cleaner. What are your thoughts on that?

Currently the VAT validator check mainly EU countries VAT but

• San Morino is not in the EU https://github.com/ibericode/vat/blob/master/src/Validator.php#L45
• GB is not in the EU anymore https://github.com/ibericode/vat/blob/master/src/Validator.php#L29 and XI/XU prefix should be supported
• People are looking for more VAT support (like upd Vat validation #57 or add hasPattern to Validator #40 (comment) which use it for Norway)

IMHO, in the futur this lib should support all possible VAT prefix and have the related regex.
One issue we currently have with the Validator is the fact that we don't know if the error is coming from an invalid pattern FR12 (for instance), an invalid country XX or a not yet supported country RU (for instance).

Instead it is better for the API to have

if (! isset($this->patterns[$country])) {
     throw new \InvalidArgumentException('The country prefix is invalid or not implemented yet');
}

but this still require to expose the hasSupportedCountryPrefix method.

We can also throw a custom VatException (?)

Currently the VAT validator check mainly EU countries VAT but

• San Morino is not in the EU master/src/Validator.php#L45
• GB is not in the EU anymore master/src/Validator.php#L29 and XI/XU prefix should be supported
• People are looking for more VAT support (like upd Vat validation #57 or add hasPattern to Validator #40 (comment) which use it for Norway)

IMHO, in the futur this lib should support all possible VAT prefix and have the related regex. One issue we currently have with the Validator is the fact that we don't know if the error is coming from an invalid pattern FR12 (for instance), an invalid country XX or a not yet supported country RU (for instance).

Instead it is better for the API to have

if (! isset($this->patterns[$country])) {
     throw new \InvalidArgumentException('The country prefix is invalid or not implemented yet');
}

but this still require to expose the hasSupportedCountryPrefix method.

We can also throw a custom VatException (?)

WDYT @dannyvankooten

Hi @VincentLanglet,

I'd like to go with throwing an InvalidArgumentException() when any of the validateVatNumber* methods are called with an unsupported country prefix. I'm fine with having an additional method to check for support before this method is called, but alternatively people could also catch the exception to accomplish the same.

Since we're not in need of this functionality ourselves and I am starting a new job soon, I don't have any time to work on this for the next few months though.

Hi @VincentLanglet,

I'd like to go with throwing an InvalidArgumentException() when any of the validateVatNumber* methods are called with an unsupported country prefix. I'm fine with having an additional method to check for support before this method is called, but alternatively people could also catch the exception to accomplish the same.

Hi, I changed to the throw exception behavior.

HI @dannyvankooten ; do you have some time to review/merge this ? Thanks.