Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes inside parentheses #10

Open
jnsprnw opened this issue Sep 1, 2023 · 0 comments
Open

Quotes inside parentheses #10

jnsprnw opened this issue Sep 1, 2023 · 0 comments

Comments

@jnsprnw
Copy link

jnsprnw commented Sep 1, 2023

This library doesn’t look too active, but maybe this fix could still be made.

The regex won't catch the quotes if the preceding character is a parenthesis:
This is a test ("Another test") inside.

I believe, a quick fix would be this regex: (^|\s|\()(?:"(.*?)"|'(.*?)')(\s|$|\.|,|\?|!|\))

I’m not sure if this could happen, but it should be covered as well: This is a test ["Another test"] inside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant