Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font no longer works after lesson-5 #3

Open
jhubbardsf opened this issue Jan 10, 2022 · 0 comments
Open

Font no longer works after lesson-5 #3

jhubbardsf opened this issue Jan 10, 2022 · 0 comments

Comments

@jhubbardsf
Copy link

jhubbardsf commented Jan 10, 2022

I noticed that when I switch to branch level-6 the font no longer works. I checked the differences and you seem to have changed the format from "truetype" to "tff" which is not a valid format. "truetype" is correct. Also, the ending semicolon is changed to a comma which breaks it. So after level 5, line 50 of style.css becomes

src: url("assets/fonts/Rubik-Regular.ttf") format("ttf"),

when it needs to stay

src: url("assets/fonts/Rubik-Regular.ttf") format("truetype");

I submitted pull requests fixing the affected branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant