-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nth child background color weirdness on dark mode old reddit #25
Comments
Upon more investigation, it seems that this is an |
Root cause seems to be that RES is listening to click events that bubble up to the Possible Solutions:
In general, I'd leave this as a low priority, as it only affects users on the old Reddit with RES. |
Note: this affects both light and dark mode on RES, so it's quite annoying. |
@azizLIGHT - Pinging you since you've been helpful and curious if you've seen this (I know you use quite a bit of extensions). Do you use rComments w/ RES on old reddit? and if so, does the "active" stylings on "Next Reply" click annoy you? I'm assuming the "active" class is important since RES allows traversing comments via keys, so I'm curious if you have an opinion. Again, my hopeful fix is to still allow the highlighting to continue, but just not automatically highlight the comment when you click the "Next Reply". |
This is what I see on old reddit with RES dark mode: Peek.2021-06-18.13-32.mp4Honestly its not a bother to me, its sort of useful maybe? Though I can get it to highlight multiple comments after I click the body of a subcomment and load a new parent comment and click it's next reply link. Either way I'm not that concerned with it but maybe it bothers other people? Peek.2021-06-18.13-39.mp4It's upto you how you want to handle it! |
Summary
To recreate, go to
https://old.reddit.com/r/soccer/
with RES dark mode. After hovering on a comment, clicking "next reply" seems to trigger a swap of background color. Plus, the background color of each comment seems to be applied on the wrong element.The text was updated successfully, but these errors were encountered: