Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong ms conversion #2769

Open
valentin78 opened this issue Nov 18, 2024 · 2 comments · May be fixed by #2771
Open

Wrong ms conversion #2769

valentin78 opened this issue Nov 18, 2024 · 2 comments · May be fixed by #2771

Comments

@valentin78
Copy link

valentin78 commented Nov 18, 2024 •
edited
Loading

Getting issue with parse datetime
created small unit test to show the issue

    const ds = '2024-11-18T02:04:48.19';
    expect(dayjs(ds).valueOf()).toEqual(new Date(ds).valueOf());
    // error: Expected 1731913488019 to equal 1731913488190.
@valentin78
Copy link
Author

PS it works if I parse '2024-11-18T02:04:48.19Z' (i.e. UTC), but fails if local time (w/o timezone)

@ChaiyoKung
Copy link

Please assign me, I'm fixing.

@ChaiyoKung ChaiyoKung linked a pull request Nov 19, 2024 that will close this issue
Open
@stoyan-karev stoyan-karev mentioned this issue Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong ms conversion ChaiyoKung/dayjs
2 participants
@valentin78 @ChaiyoKung