-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong added_in version for "handshake" variations with a single skin tone. #206
Comments
This actually looks like a bug in the unicode source files, they versioned as 3.0 here too. This looks like it crept in for a lot of other emoji since version 13 of those files. e.g.
v12 looks more correct:
I think this is only manifesting as an issue now because it's hitting brand new versions of quite old emojis. The other emojis this affects have old enough skin tones that our lib is already treating them as universally supported. |
Handshakes with skin tones are listed in version 3.0. |
Since version 13.0 the Emoji Charts version is displayed (hence the E prefix), before that the Unicode version was specified. |
Looks like they were never included in the RGI (Recommended for General Interchange) list until 14.0. They're listed as being introduced in 14.0 here https://emojipedia.org/emoji-14.0/ Some more info here https://www.unicode.org/reports/tr51/tr51-21.html#multiperson_skintones |
It's almost correct. The sequences for handshakes has been deprecated since version 4.0 (but there where listed in 3.0), but returned in version 14.0 |
OK, that's kind of awkward. I'd say the data should reflect the most recent version for cases like this. Might need to be special cased in the build if that info isn't available from any unicode.org source files. |
Pay attention to this:
|
I understand, but that's not helpful in this case for anyone trying to determine compatibility of native emoji rendering while supporting a range of different OS versions. |
These are listed as 3.0, but 3.0 didn't have skin toned handshakes. The multi skin tone versions are correctly listed as 14.0.
This prevents correct browser support detection in our fork of the js lib.
The text was updated successfully, but these errors were encountered: