Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing emojis are rendered using Apple's (?) images #162

Closed
Rohansi opened this issue Dec 2, 2019 · 4 comments
Closed

Missing emojis are rendered using Apple's (?) images #162

Rohansi opened this issue Dec 2, 2019 · 4 comments
Milestone

Comments

@Rohansi
Copy link

Rohansi commented Dec 2, 2019

Some missing emoji are rendered using a different set, such as the bagel and mango.

Here's a screenshot of the Google set (32px). These are clearly not from Google's font because the style is very different.
image

This can be a problem with licensing because those images are more restricted from use than the other Google ones, for example if being used in a commercial product.

@iamcal
Copy link
Owner

iamcal commented Jan 10, 2020

If you need to build the sheets without fallback images for missing code points (all the different sets are missing some combination of images), then you can modify the following line in build/build_image.php and rebuilt your sheets:

$try_order = array($type, 'apple', 'google', 'twitter', 'facebook');

@iamcal iamcal closed this as completed Jan 10, 2020
@iamcal iamcal added this to the v4.2.0 milestone Jan 10, 2020
@iamcal iamcal reopened this Jan 10, 2020
@iamcal iamcal closed this as completed Jan 11, 2020
@Rohansi
Copy link
Author

Rohansi commented Jan 11, 2020

If that is the case then you should add a warning message to this section of the README stating that the files included in the repo are not safe to use, and that you should build it yourself with the sets you are legally allowed to use.

https://github.com/iamcal/emoji-data#image-sources

It's very misleading providing image sets labelled as "google" and "twitter", stating that they allow commercial usage, but including Apple's images in those sets means they do not allow commercial usage.

@iamcal
Copy link
Owner

iamcal commented Jan 15, 2020

This is a great point - i'm addressing it in #166

@iamcal iamcal reopened this Jan 15, 2020
@iamcal
Copy link
Owner

iamcal commented Jan 15, 2020

v5.0.1 provides the 'clean' sheets and updates the docs to make this more clear

@iamcal iamcal closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants