Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VICTORY HAND emoji doesn't have emoji modifiers #105

Closed
yantene opened this issue Nov 29, 2017 · 6 comments
Closed

VICTORY HAND emoji doesn't have emoji modifiers #105

yantene opened this issue Nov 29, 2017 · 6 comments

Comments

@yantene
Copy link

yantene commented Nov 29, 2017

In previous version, VICTORY HAND emoji had emoji modifiers.
What's the reason?

@yantene
Copy link
Author

yantene commented Nov 29, 2017

The following emoji's emoji modifier seems to disappear.

  • weight_lifter
  • golfer
  • man_in_business_suit_levitating
  • sleuth_or_spy
  • raised_hand_with_fingers_splayed
  • point_up
  • person_with_ball
  • v
  • writing_hand

@iamcal
Copy link
Owner

iamcal commented Nov 30, 2017

Do you mean the variation selector U+FE0F? Those are now conforming to the Unicode 10 / Emoji 5 spec. The main codepoint includes a variation selector where appropriate and a non_qualified version without it.

@yantene
Copy link
Author

yantene commented Nov 30, 2017

Thank you for your reply.

I mean skin color modifier.
Although I think that the emojis should have skin color,
They don't have it.

@iamcal
Copy link
Owner

iamcal commented Dec 8, 2017

good catch - i'm looking into why these are missing

@iamcal
Copy link
Owner

iamcal commented Dec 8, 2017

this was related to non-qualified/fully-qualified codepoints. the 9 you noted use fully qualified forms (with -FE0F) when used alone, but drop the modifier when used with skin tones. this wasn't handled correctly when building the map. i'm fixing this in PR #110 which will also include all the missing images and updated sheets.

@iamcal
Copy link
Owner

iamcal commented Dec 8, 2017

now fixed on master and in 4.0.1

no downstream libraries have been updated yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants