-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debugging for browser-based tests, add debugging section to CONTRIBUTING.md #7767
Conversation
@markschlosseratbentley @andremig-bentley would you be able to try setting a breakpoint in core frontend, following the instructions here? Looking for feedback on whether the instructions are clear enough |
Are breakpoints working for you in VSCode on this branch? I tried setting some in core/frontend/src/test/Viewport.test.ts inside "Viewport", "constructor", "invokes initialize method", but they remain unbound. Is that link supposed to discuss breakpoints? I see discussion at that linked section about selecting only a single test to run. |
It's not explicitly calling out breakpoints, I guess it's implied that one knows how to set breakpoints, it's more so an explanation on how to run debugging in core.
Yes, breakpoints are working for me, I just set a breakpoint in Viewport.test.ts as well, and ran the |
Oh, interesting. I was trying "Electron Frontend Tests". Edit: I should have been trying "Frontend Tests". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me --- with the latest timeout included.
Part of #7691
For tests using vitest browser:
pnpm
to execute vitest as part of a package.json script, within a debugging launch config, the attached debugger couldn't pick up the breakpoints. Resorted to directly executing the compiled vitest source as written in vitest's docs.