Fix hopper item duplication (#2052)

JackNoordhuis · dktapps · commit b816e46335cf · 2016-10-10T13:20:30.000+01:00
This prevents items being pulled/sucked into multiple hoppers on the same tick.
diff --git a/src/pocketmine/tile/Hopper.php b/src/pocketmine/tile/Hopper.php
@@ -99,7 +99,7 @@ public function onUpdate(){
 		$area = clone $this->getBlock()->getBoundingBox(); //Area above hopper to draw items from
 		$area->maxY = ceil($area->maxY) + 1; //Account for full block above, not just 1 + 5/8
 		foreach($this->getLevel()->getChunkEntities($this->getBlock()->x >> 4, $this->getBlock()->z >> 4) as $entity){
-			if(!($entity instanceof DroppedItem)){
+			if(!($entity instanceof DroppedItem) or !$entity->isAlive()){
 				continue;
 			}
 			if(!$entity->boundingBox->intersectsWith($area)){

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ public function onUpdate(){`
`99`	`99`	`$area = clone $this->getBlock()->getBoundingBox(); //Area above hopper to draw items from`
`100`	`100`	`$area->maxY = ceil($area->maxY) + 1; //Account for full block above, not just 1 + 5/8`
`101`	`101`	`foreach($this->getLevel()->getChunkEntities($this->getBlock()->x >> 4, $this->getBlock()->z >> 4) as $entity){`
`102`		`- if(!($entity instanceof DroppedItem)){`
	`102`	`+ if(!($entity instanceof DroppedItem) or !$entity->isAlive()){`
`103`	`103`	`continue;`
`104`	`104`	`}`
`105`	`105`	`if(!$entity->boundingBox->intersectsWith($area)){`