Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better include of template files #19

Open
gbrivady opened this issue Jan 22, 2023 · 0 comments
Open

Better include of template files #19

gbrivady opened this issue Jan 22, 2023 · 0 comments
Labels
build Anything regarding the build system Priority : Not planned Anything that isn't planned yet

Comments

@gbrivady
Copy link
Member

See the end of box.h. This is not ideal for two reason :

  • Include path is explicit, which is not great if we were to move the template implementation to another place
  • There is a recursive include in box.tpp so C++ LSPs don't complain (ymmv)

Same issue in rectangle.h/rectangle.tpp.

Ideally, someone should look up conventions or other projects that use template file so we can both:

  1. Find a better way to split include and template files
  2. Decide if the split is even a good or idea, or if we should just stick with a simgle .h or .tpp file.
@gbrivady gbrivady added Priority : Not planned Anything that isn't planned yet build Anything regarding the build system labels Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Anything regarding the build system Priority : Not planned Anything that isn't planned yet
Projects
Status: Not planned
Development

No branches or pull requests

1 participant