Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented fc display in mag align helper tool #1801

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

RomanLut
Copy link
Contributor

@RomanLut RomanLut commented Jul 4, 2023

image

@DzikuVx
Copy link
Member

DzikuVx commented Jul 4, 2023

Nice!

@DzikuVx DzikuVx added this to the 7.0 milestone Jul 4, 2023
@DzikuVx DzikuVx merged commit 187806c into iNavFlight:master Jul 4, 2023
@rts18
Copy link

rts18 commented Jul 19, 2023

Roman, I've checked out these changes, and there appears to be conflicting calculations between align_mag and align_mag_yaw.

  • Align_mag or orientate preset is obviously based on the hardware designers component mounting of the magnetometer chip, and referenced by the arrow on the device. This setting should only be adjusted to suit the hardware specifications.
  • While align_mag_yaw is a software setting used to adjust the mounting position of the device in the craft. Which uses the compass arrow as a reference marker for this purpose.

The problem I've observed when the flight controller board has a different Yaw mounting position. And the Yaw slider is moved to set the compass arrows direction according to its mounting orientation in the craft. Is the orientation preset become shaded and requires it to be changed to line up with align_mag_yaw. With it also locking up the Configurator.
This makes no sense, because the orientation preset should not be changed from the manufactures specification. But if it isn't changed the Gyro and Mag will clash.
And once orientation preset is changed to suit the tools requirements, it becomes a mess when trying to workout the actual align_mag position based on the arrow and magnetometer hardware..

@RomanLut
Copy link
Contributor Author

I hope now everything works correctly:
#1806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants