Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project no longer compiles #27

Open
mazz opened this issue Feb 5, 2024 · 2 comments
Open

Project no longer compiles #27

mazz opened this issue Feb 5, 2024 · 2 comments

Comments

@mazz
Copy link

mazz commented Feb 5, 2024

The project is locked onto membrane master branch but unfortunately membrane has undergone a major overhaul to their repository structure. This means that simply doing

mix deps.get
mix ecto.reset

will result in many misssing dependencies and compile-time errors.

will you consider refactoring the project for the new membrane repo?

@madawei2699
Copy link
Collaborator

Thanks, but I have no plan to refactor this product for now but will do it if I have free time.

@mazz
Copy link
Author

mazz commented Mar 15, 2024

Thanks, but I have no plan to refactor this product for now but will do it if I have free time.

I almost got this to compile with these dependencies(and elixir 1.14.x) but because I need SimulcastConfig%{} from a newer library, compilation fails

  {:membrane_rtc_engine, "== 0.9.1"},
  {:membrane_webrtc_plugin, "== 0.11.0"},
  {:membrane_core, "== 0.10.0"},

but I get this error:

== Compilation error in file lib/free4chat/room.ex ==
** (KeyError) key :default_encoding not found
    (membrane_rtc_engine 0.9.1) expanding struct: Membrane.RTC.Engine.Endpoint.WebRTC.SimulcastConfig.__struct__/1
    lib/free4chat/room.ex:148: Free4chat.Room.handle_info/2

Strangely, this is in a much newer library:

https://hexdocs.pm/membrane_rtc_engine_webrtc/0.1.0/Membrane.RTC.Engine.Endpoint.WebRTC.SimulcastConfig.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants