Skip to content

feat: request includeInactive for all entity id queries #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021
Merged

feat: request includeInactive for all entity id queries #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61e8ad2
feat: request includeInactive for all entity id queries
jake-bassett Mar 24, 2021
bf5b9b7
feat: includeInactive is configurable defaulting to true
jake-bassett Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ed/graphql/request/handlers/entities/query/entity/entity-graphql-query-handler.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
} from '@hypertrace/graphql-client';
import { Observable } from 'rxjs';
import { map, throwIfEmpty } from 'rxjs/operators';
import { Entity, EntityType, ObservabilityEntityType } from '../../../../../model/schema/entity';
import { Entity, EntityType } from '../../../../../model/schema/entity';
import { GraphQlEntityFilter } from '../../../../../model/schema/filter/entity/graphql-entity-filter';
import { EntitiesGraphqlQueryBuilderService } from '../entities-graphql-query-builder.service';
import {
Expand Down Expand Up @@ -57,8 +57,8 @@ export class EntityGraphQlQueryHandlerService implements GraphQlQueryHandler<Gra
timeRange: request.timeRange,
properties: request.properties,
filters: [new GraphQlEntityFilter(request.id, request.entityType)],
// If querying for a single API, then always want to includeInactive
includeInactive: request.entityType === ObservabilityEntityType.Api
// If querying for a single API by ID, then usually want to includeInactive
includeInactive: request.includeInactive !== false
};
}
}
Expand All @@ -71,4 +71,5 @@ export interface GraphQlEntityRequest {
id: string;
properties: Specification[];
timeRange: GraphQlTimeRange;
includeInactive?: boolean;
}
3 changes: 2 additions & 1 deletion ...equest/handlers/entities/query/interactions/interactions-graphql-query-handler.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ export class InteractionsGraphQlQueryHandlerService
id: request.entityId,
entityType: request.entityType,
properties: [],
timeRange: request.timeRange
timeRange: request.timeRange,
includeInactive: false
};
}

Expand Down