fix: naming and removed trivial method

Author: jake-bassett

projects/distributed-tracing/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts

@@ -17,7 +17,6 @@ import {
   TableColumnConfig,
   TableDataSource,
   TableFilter,
-  TableMode,
   TableRow,
   TableSelectionMode,
   TableStyle,
@@ -72,7 +71,7 @@ import { TableWidgetModel } from './table-widget.model';
           [ngClass]="{ 'header-margin': this.model.header?.topMargin }"
           [columnConfigs]="this.columnConfigs$ | async"
           [metadata]="this.metadata$ | async"
-          [mode]="this.activeMode"
+          [mode]="this.model.mode"
           [selectionMode]="this.model.getSelectionMode()"
           [display]="this.model.style"
           [data]="this.data$ | async"
@@ -97,7 +96,6 @@ export class TableWidgetRendererComponent
   implements OnInit {
   public filterItems: ToggleItem<TableWidgetFilterModel>[] = [];
   public viewItems: ToggleItem<string>[] = [];
-  public activeMode!: string;
 
   public selectFilterItems$!: Observable<SelectFilter[]>;
 
@@ -124,8 +122,6 @@ export class TableWidgetRendererComponent
   public ngOnInit(): void {
     super.ngOnInit();
 
-    this.onModeChange(this.model.mode);
-
     this.metadata$ = this.getScopeAttributes();
     this.columnConfigs$ = (isNonEmptyString(this.model.id)
       ? this.preferenceService.get<TableColumnConfig[]>(this.model.id, [])
@@ -328,10 +324,6 @@ export class TableWidgetRendererComponent
     this.searchFilterSubject.next([searchFilter]);
   }
 
-  public onModeChange(mode: TableMode): void {
-    this.activeMode = mode;
-  }
-
   public onViewChange(view: string): void {
     this.model.setView(view);
     this.columnConfigs$ = this.getColumnConfigs();

projects/distributed-tracing/src/shared/dashboard/widgets/table/table-widget-view-toggle.model.ts

@@ -41,11 +41,11 @@ export class TableWidgetViewToggleModel extends TableWidgetBaseModel {
   }
 
   public getViewOptions(): string[] {
-    return this.views.map(v => v.view);
+    return this.views.map(v => v.label);
   }
 
   private createDelegate(view: string): TableWidgetModel | undefined {
-    const found = this.views.find(v => v.view.toLowerCase() === view.toLowerCase());
+    const found = this.views.find(v => v.label.toLowerCase() === view.toLowerCase());
 
     return found ? this.api.createChild<TableWidgetModel>(found.template) : undefined;
   }

projects/distributed-tracing/src/shared/dashboard/widgets/table/table-widget-view.model.ts

@@ -6,10 +6,10 @@ import { Model, ModelJson, ModelProperty, STRING_PROPERTY } from '@hypertrace/hy
 })
 export class TableWidgetViewModel {
   @ModelProperty({
-    key: 'view',
+    key: 'label',
     type: STRING_PROPERTY.type
   })
-  public view!: string;
+  public label!: string;
 
   @ModelProperty({
     key: 'template',