refactor: moving entity navigation handler to use modelinject (#305)

Author: anandtiwary

projects/observability/src/shared/dashboard/interactions/entity/handler-service/dashboard-entity-navigation-handler.service.test.ts

@@ -0,0 +1,28 @@
+import { createModelFactory } from '@hypertrace/dashboards/testing';
+import { mockProvider } from '@ngneat/spectator/jest';
+import { Entity, entityIdKey, entityTypeKey, ObservabilityEntityType } from '../../../../graphql/model/schema/entity';
+import { EntityNavigationService } from '../../../../services/navigation/entity/entity-navigation.service';
+import { EntityNavigationHandlerModel } from './entity-navigation-handler.model';
+
+describe('Entity Navigation Handler Model', () => {
+  const entity: Entity = {
+    [entityIdKey]: 'test-id',
+    [entityTypeKey]: ObservabilityEntityType.Api
+  };
+
+  const buildModel = createModelFactory({
+    providers: [
+      mockProvider(EntityNavigationService, {
+        navigateToEntity: jest.fn()
+      })
+    ]
+  });
+
+  test('calls navigateToEntity with correct parameters', () => {
+    const spectator = buildModel(EntityNavigationHandlerModel);
+    const navService = spectator.get(EntityNavigationService);
+
+    spectator.model.execute(entity);
+    expect(navService.navigateToEntity).toHaveBeenLastCalledWith(entity);
+  });
+});

projects/observability/src/shared/dashboard/interactions/entity/handler-service/dashboard-entity-navigation-handler.service.ts

@@ -1,18 +1,19 @@
 import { InteractionHandler } from '@hypertrace/distributed-tracing';
-import { Model, ModelEventPublisher } from '@hypertrace/hyperdash';
-import { Observable, of, Subject } from 'rxjs';
+import { Model } from '@hypertrace/hyperdash';
+import { ModelInject } from '@hypertrace/hyperdash-angular';
+import { Observable, of } from 'rxjs';
 import { Entity } from '../../../../graphql/model/schema/entity';
-import { DashboardEntityNavigationHandlerService } from '../handler-service/dashboard-entity-navigation-handler.service';
+import { EntityNavigationService } from '../../../../services/navigation/entity/entity-navigation.service';
 
 @Model({
   type: 'entity-navigation-handler'
 })
 export class EntityNavigationHandlerModel implements InteractionHandler {
-  @ModelEventPublisher(DashboardEntityNavigationHandlerService)
-  protected readonly navigate$: Subject<Entity> = new Subject();
+  @ModelInject(EntityNavigationService)
+  private readonly entityNavService!: EntityNavigationService;
 
   public execute(entity: Entity): Observable<void> {
-    this.navigate$.next(entity);
+    this.entityNavService.navigateToEntity(entity);
 
     return of();
   }