refactor: addressing review comments

Author: itssharmasandeep

projects/distributed-tracing/src/shared/dashboard/widgets/waterfall/waterfall/span-name/span-name-cell-data.ts

@@ -3,5 +3,5 @@ export interface SpanNameCellData {
   protocolName: string;
   name: string;
   color?: string;
-  error?: boolean;
+  hasError?: boolean;
 }

projects/distributed-tracing/src/shared/dashboard/widgets/waterfall/waterfall/span-name/span-name-table-cell-renderer.component.test.ts

@@ -45,7 +45,7 @@ describe('Span name table cell renderer component', () => {
     const spanNameDataWithColor = {
       ...spanNameData,
       color: 'blue',
-      error: true
+      hasError: true
     };
     const spectator = buildComponent({
       providers: [tableCellDataProvider(spanNameDataWithColor)]

projects/distributed-tracing/src/shared/dashboard/widgets/waterfall/waterfall/span-name/span-name-table-cell-renderer.component.ts

@@ -22,7 +22,7 @@ import { WaterfallTableCellType } from './span-name-cell-type';
         <span class="text" data-sensitive-pii>{{ this.value.name }}</span>
       </div>
       <ht-icon
-        *ngIf="this.value.error"
+        *ngIf="this.value.hasError"
         class="error-icon"
         icon="${IconType.Error}"
         size="${IconSize.Medium}"

projects/distributed-tracing/src/shared/dashboard/widgets/waterfall/waterfall/waterfall-chart.service.ts

@@ -42,7 +42,7 @@ export class WaterfallChartService {
           name: datum.name,
           serviceName: datum.serviceName,
           protocolName: datum.protocolName,
-          error: datum.errorCount > 0
+          hasError: datum.errorCount > 0
         },
         $$iconType: this.iconLookupService.forSpanType(datum.spanType)!,
         getChildren: () => of([]),
@@ -123,7 +123,7 @@ export class WaterfallChartService {
       const node = nodes.shift()!;
       let color;
 
-      if (node.$$spanName.error) {
+      if (node.$$spanName.hasError) {
         // If span contains an error
         color = Color.Red5;
       } else if (colorMap.has(node.serviceName)) {