Skip to content

Commit a6c922e

Browse files
committed
refactor: addressing review comments
1 parent bd570bd commit a6c922e

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

projects/assets-library/assets/icons/copy-to-clipboard.svg

Lines changed: 0 additions & 5 deletions
This file was deleted.

projects/assets-library/src/icons/icon-library.module.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ const iconsRootPath = 'assets/icons';
3737
{ key: IconType.CollapseAll, url: `${iconsRootPath}/collapse-all.svg` },
3838
{ key: IconType.Collapsed, url: `${iconsRootPath}/plus-square.svg` },
3939
{ key: IconType.Compare, url: `${iconsRootPath}/compare.svg` },
40-
{ key: IconType.CopyToClipboard, url: `${iconsRootPath}/copy-to-clipboard.svg` },
4140
{ key: IconType.Custom, url: `${iconsRootPath}/custom.svg` },
4241
{ key: IconType.Dashboard, url: `${iconsRootPath}/dashboard.svg` },
4342
{ key: IconType.Device, url: `${iconsRootPath}/device.svg` },

projects/assets-library/src/icons/icon-type.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export const enum IconType {
3030
Compare = 'svg:compare',
3131
CompareArrows = 'compare_arrows',
3232
ContentCopy = 'content_copy',
33-
CopyToClipboard = 'svg:copy-to-clipboard',
3433
Code = 'svg:code',
3534
Custom = 'svg:custom',
3635
CustomWebhook = 'svg:custom-webhook',

projects/components/src/copy-to-clipboard/copy-to-clipboard.component.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,11 @@ describe('Copy to Clipboard component', () => {
3232

3333
test('correctly copies the text to clipboard', fakeAsync(() => {
3434
spectator = createHost(
35-
`<ht-copy-to-clipboard [text]="textToBeCopied" label="Copy to Clipboard"></ht-copy-to-clipboard>`,
35+
`<ht-copy-to-clipboard [tooltipDuration]="tooltipDuration" [text]="textToBeCopied" label="Copy to Clipboard"></ht-copy-to-clipboard>`,
3636
{
3737
hostProps: {
38-
textToBeCopied: 'Text to be copied'
38+
textToBeCopied: 'Text to be copied',
39+
tooltipDuration: 1000
3940
}
4041
}
4142
);
@@ -62,7 +63,7 @@ describe('Copy to Clipboard component', () => {
6263

6364
spectator.tick();
6465
expect(spectator.inject(PopoverService).drawPopover).toHaveBeenCalled();
65-
spectator.tick(4000);
66+
spectator.tick(1001);
6667
expect(mockPopoverRef.close).toHaveBeenCalled();
6768
}));
6869
});

0 commit comments

Comments
 (0)