Skip to content

Commit 4ffe783

Browse files
fix: addressing review comments
1 parent ae8177a commit 4ffe783

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

projects/components/src/list-view/list-view.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import { ListViewValueRendererDirective } from './list-view-value-renderer.direc
55
styleUrls: ['./list-view.component.scss'],
66
changeDetection: ChangeDetectionStrategy.OnPush,
77
template: `
8+
<ng-template #defaultValueRenderer let-record
9+
><span>{{ record.value }}</span></ng-template
10+
>
811
<div class="list-view">
912
<div *ngIf="this.header" class="header-row">
1013
<div class="header-key-label">
@@ -26,9 +29,6 @@ import { ListViewValueRendererDirective } from './list-view-value-renderer.direc
2629
"
2730
></ng-container>
2831
</div>
29-
<ng-template #defaultValueRenderer let-record
30-
><span>{{ record.value }}</span></ng-template
31-
>
3232
</div>
3333
</div>
3434
`

projects/observability/src/shared/components/span-detail/span-detail.component.test.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,14 @@
1-
import { HttpClientTestingModule } from '@angular/common/http/testing';
21
import { fakeAsync } from '@angular/core/testing';
3-
import { IconLibraryTestingModule } from '@hypertrace/assets-library';
4-
import { NavigationService } from '@hypertrace/common';
5-
import { createHostFactory, mockProvider, Spectator } from '@ngneat/spectator/jest';
6-
import { ExplorerService } from '../../../pages/explorer/explorer-service';
2+
import { createHostFactory, Spectator } from '@ngneat/spectator/jest';
73
import { SpanData } from './span-data';
84
import { SpanDetailComponent } from './span-detail.component';
9-
import { SpanDetailModule } from './span-detail.module';
105

116
describe('Span detail component', () => {
127
let spectator: Spectator<SpanDetailComponent>;
138

149
const createHost = createHostFactory({
1510
component: SpanDetailComponent,
16-
imports: [SpanDetailModule, HttpClientTestingModule, IconLibraryTestingModule],
17-
declareComponent: false,
18-
providers: [mockProvider(NavigationService), mockProvider(ExplorerService)]
11+
shallow: true
1912
});
2013

2114
test('should display child components', () => {

0 commit comments

Comments
 (0)