Skip to content

Commit 2863c9e

Browse files
palbizuPatricio Albizu
andauthored
feat: removing unused type in tickCount variable (#1048)
Co-authored-by: Patricio Albizu <[email protected]>
1 parent a362318 commit 2863c9e

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@
5656
"d3-scale": "^3.3.0",
5757
"d3-selection": "^1.4.2",
5858
"d3-shape": "^1.3.5",
59-
"d3-time": "^2.1.1",
6059
"d3-transition": "^1.2.0",
6160
"d3-zoom": "^1.8.3",
6261
"graphql": "^15.5.1",

projects/observability/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
"d3-path": "^1.0.9",
3030
"d3-hierarchy": "^1.1.9",
3131
"d3-axis": "^1.0.12",
32-
"d3-quadtree": "^1.0.6",
33-
"d3-time": "^2.1.1"
32+
"d3-quadtree": "^1.0.6"
3433
},
3534
"devDependencies": {
3635
"@hypertrace/test-utils": "^0.0.0"

projects/observability/src/shared/components/cartesian/chart.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { TimeRange } from '@hypertrace/common';
2-
import { TimeInterval } from 'd3-time';
32
import { LegendPosition } from '../legend/legend.component';
43
import { ChartTooltipRef } from '../utils/chart-tooltip/chart-tooltip-popover';
54
import { ChartEvent, ChartEventListener } from './chart-interactivty';
@@ -126,9 +125,9 @@ export interface Axis {
126125
max?: number;
127126

128127
/**
129-
* Determine the tick count labels (number or time interval)
128+
* Determine the tick count labels
130129
*/
131-
tickCount?: number | TimeInterval;
130+
tickCount?: number;
132131
}
133132

134133
export interface AxisCrosshair {

projects/observability/src/shared/components/cartesian/d3/axis/cartesian-axis.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { Axis as D3Axis, axisBottom, AxisDomain, axisLeft, axisRight, AxisScale, axisTop } from 'd3-axis';
22
import { BaseType, select, Selection } from 'd3-selection';
3-
import { TimeInterval } from 'd3-time';
43
import { defaultsDeep } from 'lodash-es';
54
import { MouseLocationData } from '../../../utils/mouse-tracking/mouse-tracking';
65
import { SvgUtilService } from '../../../utils/svg/svg-util.service';
@@ -188,7 +187,7 @@ export class CartesianAxis<TData = {}> {
188187
}
189188
}
190189

191-
private calculateAxisTickCount(): number | TimeInterval {
190+
private calculateAxisTickCount(): number {
192191
if (this.configuration?.tickCount !== undefined) {
193192
return this.configuration.tickCount;
194193
}

0 commit comments

Comments
 (0)