Skip to content

Commit 004ac73

Browse files
fix: make explorer content scrollable
1 parent 2a2e427 commit 004ac73

File tree

2 files changed

+17
-24
lines changed

2 files changed

+17
-24
lines changed

projects/observability/src/pages/explorer/explorer.component.scss

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import 'font';
2+
@import 'layout';
23

34
.explorer {
45
display: flex;
@@ -11,21 +12,19 @@
1112
}
1213

1314
.explorer-content {
15+
@include scrollable-container(24px);
1416
display: flex;
1517
flex-direction: column;
16-
padding: 24px 24px 0;
17-
flex: 1;
18-
min-height: 0;
1918
}
2019

2120
.explorer-data-toggle {
2221
flex: 0;
23-
padding-bottom: 16px;
22+
padding: 24px 24px 16px;
2423
}
2524

2625
.explorer-filter-bar {
2726
flex: 0;
28-
padding-bottom: 8px;
27+
padding: 0 24px 8px;
2928
}
3029

3130
.panel-title {
@@ -49,14 +48,9 @@
4948

5049
.results-panel {
5150
flex: 1;
52-
overflow: hidden;
5351

5452
.label {
5553
@include body-1-medium;
5654
}
57-
58-
.results-panel-content {
59-
padding-top: 12px;
60-
}
6155
}
6256
}

projects/observability/src/pages/explorer/explorer.component.ts

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,20 @@ import {
2323
template: `
2424
<div class="explorer">
2525
<ht-page-header class="explorer-header"></ht-page-header>
26+
<ht-toggle-group
27+
class="explorer-data-toggle"
28+
[items]="this.contextItems"
29+
[activeItem]="this.activeContextItem$ | async"
30+
(activeItemChange)="this.onContextUpdated($event.value)"
31+
></ht-toggle-group>
32+
33+
<ht-filter-bar
34+
class="explorer-filter-bar"
35+
[attributes]="this.attributes$ | async"
36+
[syncWithUrl]="true"
37+
(filtersChange)="this.onFiltersUpdated($event)"
38+
></ht-filter-bar>
2639
<div class="explorer-content">
27-
<ht-toggle-group
28-
class="explorer-data-toggle"
29-
[items]="this.contextItems"
30-
[activeItem]="this.activeContextItem$ | async"
31-
(activeItemChange)="this.onContextUpdated($event.value)"
32-
></ht-toggle-group>
33-
34-
<ht-filter-bar
35-
class="explorer-filter-bar"
36-
[attributes]="this.attributes$ | async"
37-
[syncWithUrl]="true"
38-
(filtersChange)="this.onFiltersUpdated($event)"
39-
></ht-filter-bar>
40-
4140
<ht-panel class="visualization-panel" [(expanded)]="this.visualizationExpanded">
4241
<ht-panel-header>
4342
<ht-panel-title [expanded]="this.visualizationExpanded"

0 commit comments

Comments
 (0)