Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove span-normalizer service #59

Open
findingrish opened this issue Nov 23, 2020 · 3 comments
Open

Remove span-normalizer service #59

findingrish opened this issue Nov 23, 2020 · 3 comments
Labels

Comments

@findingrish
Copy link
Contributor

The code in this service is basically simple transformational logic and can be easily moved to either collector or raw-spans-grouper.

cc @kotharironak @jcchavezs @buchi-busireddy

@codefromthecrypt
Copy link
Contributor

wouldn't that improve performance? :P

@jcchavezs
Copy link
Contributor

@rish691 if have time, would you describe exactly what is span-normalizer doing? Moving to collector is also a good idea cc @davexroth

@findingrish
Copy link
Contributor Author

findingrish commented Dec 2, 2020

I am a bit late in replying, sorry for that.

Let me write down what it does:
It consumes the message published by collector, in the following format:
https://github.com/hypertrace/hypertrace-ingester/blob/main/span-normalizer/span-normalizer-api/src/main/proto/jaeger/jaeger_span_internal_model.proto#L88

It then converts this span data into an internal format called RawSpan:
https://github.com/hypertrace/data-model/blob/main/data-model/src/main/avro/RawSpan.avdl#L8

The key difference between the input & output schema is some first class fields https://github.com/hypertrace/data-model/tree/main/data-model/src/main/avro/eventfields
These fields are populated by some if/else logic over the input data attributes.

I feel, running this job as standalone service is not necessary and can be merged with an existing service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants