New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Graph Building/Optimisation logic into a different module #110

Open

findingrish opened this issue Jan 12, 2021 · 0 comments

Labels

Contributor

findingrish commented Jan 12, 2021 •

edited

Loading

This module https://github.com/hypertrace/hypertrace-ingester/tree/main/hypertrace-trace-enricher/hypertrace-trace-enricher-api, has classes for building ApiTraceGraph and StructuredTraceGraph
Also this class https://github.com/hypertrace/hypertrace-ingester/blob/main/hypertrace-view-generator/hypertrace-view-generator/src/main/java/org/hypertrace/viewgenerator/generators/ViewGeneratorState.java has logic for building ViewGenerator state and threadlocal related code for caching state.

These should be moved into a different module (data-model being one option).

Also consider refactoring/optimising the Graph building logic, since it is part of a critical code path.

kotharironak added the refactor label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment