chore: update exclude span rule schema #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
=========================================
Coverage 22.80% 22.80%
Complexity 75 75
=========================================
Files 65 65
Lines 1741 1741
Branches 53 53
=========================================
Hits 397 397
Misses 1335 1335
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
skjindal93
reviewed
Sep 5, 2022
| RuleType convertExcludeSpanRuleRuleType(ExcludeSpanRuleRuleType ruleType) { | ||
| // TODO: remove this check after making this field non-nullable | ||
| if (ruleType == null) { | ||
| return RuleType.RULE_TYPE_UNSPECIFIED; |
Contributor
Author
There was a problem hiding this comment.
Ah, right. Updated it now.
| case RULE_TYPE_SYSTEM: | ||
| case RULE_TYPE_UNSPECIFIED: // required to cater for the older user configs(as they didn't | ||
| // have a rule type field) | ||
| return ExcludeSpanRuleRuleType.SYSTEM; |
Contributor
Author
There was a problem hiding this comment.
Right😅, updated it now.
skjindal93
approved these changes
Sep 5, 2022
skjindal93
pushed a commit
that referenced
this pull request
Jun 21, 2024
Co-authored-by: aaron-steinfeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the rule type field for exclude span rules to distinguish between system exclude span rules and user exclude span rules. Depends on hypertrace/config-service#133.
Checklist: