Skip to content

Commit 1c64f19

Browse files
drop api spec based naming rules (#151)
1 parent 1c84a49 commit 1c64f19

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

hypertrace-graphql-platform/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ dependencies {
1313
api("org.hypertrace.config.service:spaces-config-service-api:0.1.1")
1414
api("org.hypertrace.config.service:labels-config-service-api:0.1.15")
1515
api("org.hypertrace.config.service:label-application-rule-config-service-api:0.1.16")
16-
api("org.hypertrace.config.service:span-processing-config-service-api:0.1.36")
16+
api("org.hypertrace.config.service:span-processing-config-service-api:0.1.38")
1717
}
1818
}

hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/dao/ConfigServiceSpanProcessingResponseConverter.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.hypertrace.graphql.spanprocessing.dao;
22

3+
import static org.hypertrace.span.processing.config.service.v1.ApiNamingRuleConfig.RuleConfigCase.API_SPEC_BASED_CONFIG;
4+
35
import io.reactivex.rxjava3.core.Maybe;
46
import io.reactivex.rxjava3.core.Observable;
57
import io.reactivex.rxjava3.core.Single;
@@ -51,6 +53,12 @@ private Maybe<ExcludeSpanRule> convertOrDrop(
5153

5254
private Maybe<ApiNamingRule> convertOrDrop(
5355
org.hypertrace.span.processing.config.service.v1.ApiNamingRuleDetails ruleDetails) {
56+
// drop api spec based rules
57+
if (API_SPEC_BASED_CONFIG.equals(
58+
ruleDetails.getRule().getRuleInfo().getRuleConfig().getRuleConfigCase())) {
59+
return Maybe.empty();
60+
}
61+
5462
return this.ruleConverter
5563
.convert(ruleDetails)
5664
.doOnError(error -> log.error("Error converting ApiNamingRule", error))

0 commit comments

Comments
 (0)