fix: unknown scalar not handling variable values

Author: aaron-steinfeld

hypertrace-core-graphql-common-schema/src/main/java/org/hypertrace/core/graphql/common/schema/typefunctions/UnknownScalar.java

@@ -12,7 +12,6 @@
 import graphql.language.StringValue;
 import graphql.schema.Coercing;
 import graphql.schema.CoercingParseLiteralException;
-import graphql.schema.CoercingParseValueException;
 import graphql.schema.CoercingSerializeException;
 import graphql.schema.GraphQLScalarType;
 import java.lang.reflect.AnnotatedType;
@@ -40,16 +39,17 @@ public Object serialize(Object fetcherResult) throws CoercingSerializeException
                 }
 
                 @Override
-                public Object parseValue(Object input) throws CoercingParseValueException {
-                  return this.parseFromAst(input, CoercingParseValueException::new);
+                public Object parseValue(Object input) {
+                  return input;
                 }
 
                 @Override
                 public Object parseLiteral(Object input) throws CoercingParseLiteralException {
                   return this.parseFromAst(input, CoercingParseLiteralException::new);
                 }
 
-                private <E> Object parseFromAst(Object input, Function<Exception, E> errorWrapper) {
+                private <E extends RuntimeException> Object parseFromAst(
+                    Object input, Function<Exception, E> errorWrapper) throws E {
                   Function<Object, Object> recurse =
                       value -> this.parseFromAst(value, errorWrapper);
 
@@ -81,7 +81,7 @@ private <E> Object parseFromAst(Object input, Function<Exception, E> errorWrappe
                                     field -> recurse.apply(field.getValue())));
                   }
 
-                  return errorWrapper.apply(
+                  throw errorWrapper.apply(
                       new IllegalArgumentException(
                           String.format(
                               "Unsupported input of type %s",

hypertrace-core-graphql-common-schema/src/test/java/org/hypertrace/core/graphql/common/schema/scalars/UnknownScalarTest.java

@@ -2,6 +2,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import graphql.annotations.processor.ProcessingElementsContainer;
@@ -10,6 +11,7 @@
 import graphql.language.FloatValue;
 import graphql.language.IntValue;
 import graphql.language.StringValue;
+import graphql.schema.CoercingParseLiteralException;
 import graphql.schema.GraphQLScalarType;
 import java.lang.reflect.AnnotatedType;
 import java.math.BigDecimal;
@@ -92,5 +94,21 @@ void canConvertFromLiteral() {
                 ArrayValue.newArrayValue()
                     .value(StringValue.newStringValue("five").build())
                     .build()));
+
+    assertThrows(
+        CoercingParseLiteralException.class,
+        () -> unknownScalarType.getCoercing().parseLiteral("bad value"));
+  }
+
+  @Test
+  void canConvertFromValue() {
+    // A dumb bug requires a dumb test
+    assertEquals(true, unknownScalarType.getCoercing().parseValue(true));
+
+    assertEquals("value", unknownScalarType.getCoercing().parseValue("value"));
+
+    assertEquals(10, unknownScalarType.getCoercing().parseValue(10));
+
+    assertEquals(10.5, unknownScalarType.getCoercing().parseValue(10.5));
   }
 }