Skip to content

Conversation

@aman-bansal
Copy link
Member

No description provided.

@aman-bansal aman-bansal requested a review from a team as a code owner June 20, 2024 15:27
@github-actions
Copy link

github-actions bot commented Jun 20, 2024

Test Results

 58 files  ±0   58 suites  ±0   23s ⏱️ ±0s
298 tests +2  297 ✅ +2  1 💤 ±0  0 ❌ ±0 
300 runs  +2  299 ✅ +2  1 💤 ±0  0 ❌ ±0 

Results for commit 3710ffe. ± Comparison against base commit b32b68c.

This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.
org.hypertrace.entity.query.service.converter.UpdateConverterTest ‑ [1] ATTRIBUTE_UPDATE_OPERATOR_ADD_TO_LIST_IF_ABSENT
org.hypertrace.entity.query.service.converter.UpdateConverterTest ‑ [2] ATTRIBUTE_UPDATE_OPERATOR_REMOVE_FROM_LIST
org.hypertrace.entity.data.service.EntityNormalizerTest ‑ throwsIfEntityTypeClientIsDown()
org.hypertrace.entity.query.service.converter.UpdateConverterTest ‑ [1] ATTRIBUTE_UPDATE_OPERATOR_REMOVE_FROM_LIST
org.hypertrace.entity.query.service.converter.UpdateConverterTest ‑ [2] ATTRIBUTE_UPDATE_OPERATOR_ADD_TO_LIST_IF_ABSENT
org.hypertrace.entity.query.service.converter.UpdateConverterTest ‑ testConvert_updateTimestamp_withValueTypeLong()

♻️ This comment has been updated with latest results.

@aman-bansal aman-bansal changed the title fix | fix the updates for timestamp attribute fix | fix the updates for timestamp attribute and key for update operations Jun 21, 2024
@codecov
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 12 lines in your changes missing coverage. Please review.

Project coverage is 68.96%. Comparing base (704f9fb) to head (70b9e2b).
Report is 12 commits behind head on main.

Current head 70b9e2b differs from pull request most recent head 3710ffe

Please upload reports for the commit 3710ffe to get more accurate results.

Files Patch % Lines
...e/entity/query/service/EntityQueryServiceImpl.java 47.61% 8 Missing and 3 partials ⚠️
...ntity/query/service/converter/UpdateConverter.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #294      +/-   ##
============================================
+ Coverage     68.92%   68.96%   +0.04%     
+ Complexity      665      653      -12     
============================================
  Files           111      112       +1     
  Lines          4740     4714      -26     
  Branches        498      487      -11     
============================================
- Hits           3267     3251      -16     
+ Misses         1210     1207       -3     
+ Partials        263      256       -7     
Flag Coverage Δ
integration 68.96% <69.23%> (+0.04%) ⬆️
unit 51.14% <66.66%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aman-bansal aman-bansal merged commit 8432b89 into main Jun 26, 2024
@aman-bansal aman-bansal deleted the aman/attribute_updated branch June 26, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants