Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objective C support ? #97

Closed
chlebta opened this issue Jan 21, 2016 · 12 comments
Closed

Objective C support ? #97

chlebta opened this issue Jan 21, 2016 · 12 comments

Comments

@chlebta
Copy link

chlebta commented Jan 21, 2016

Does this library work with objectiveC project and how to integrate it ?

screen shot 2016-01-21 at 11 52 44

Also ImagePickerDelegate is not visible to objectiveC class

@zenangst
Copy link
Contributor

Hey @chlebta, right now, we don't intend to support Objective-C out-of-the-box as it adds some restriction to how we implement things. But you could try something like this; https://github.com/hyperoslo/Whisper/wiki/Using-Whisper-in-Objective-C

Don't know if that will work for delegates but I hope it will, let us know how it goes.

@ItamarM
Copy link

ItamarM commented Jan 24, 2016

@chlebta i've made a fork that supports that
https://github.com/ItamarM/ImagePicker

@richardtop
Copy link
Contributor

@ItamarM as I can see, the only difference with master repo is addition of @objc keyword to protocol declaration. If so, I guess, it can be added to master repo as it won't break anything in Picker's internal implementation.

@ItamarM
Copy link

ItamarM commented Jan 25, 2016

@Richardoti 👍 looking forward.

@chlebta
Copy link
Author

chlebta commented Jan 25, 2016

@ItamarM Thank you.
@Richardoti If I found any issue I will notify you.

@zenangst
Copy link
Contributor

zenangst commented Feb 7, 2016

Hey guys, we prefer to not have @objc annotations in our implementation because it screws with Swift compiler optimisation. This is our current stance on having "native" Objective-C support for ImagePicker.

Hope you guys understand and can live with the workaround that you guys have to do to make it work.
If the need for Objective-C support becomes mainstream (as we don't think it is right now), then we will definitely reconsider changing this.

Hope you guys understand our position on this and thanks for supporting ImagePicker.
You guys are awesome!

@zenangst zenangst closed this as completed Feb 7, 2016
@ItamarM
Copy link

ItamarM commented Feb 8, 2016

sure thing @zenangst
Long live Swift (& ImagePicker) :)

@manupeco
Copy link

manupeco commented May 3, 2016

Hi @ItamarM ,
could you please explain how we can install your forked version in a project?

@richardtop
Copy link
Contributor

richardtop commented May 3, 2016

@manupeco, to install forked version, just specify other git repository in the podfile:

pod 'ImagePicker',  :git => 'https://github.com/ItamarM/ImagePicker.git'

@manupeco
Copy link

manupeco commented May 4, 2016

Thanks a lot @Richardoti

@FreudGit
Copy link

Possible to update this fork to 1.3.0? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@zenangst @ItamarM @chlebta @manupeco @FreudGit @richardtop and others