Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Disallow DQL schema changes for predicates used in GraphQL schema #8487

Closed
rderbier opened this issue Dec 5, 2022 · 1 comment
Closed

[FEATURE]: Disallow DQL schema changes for predicates used in GraphQL schema #8487

rderbier opened this issue Dec 5, 2022 · 1 comment
Labels
area/graphql Issues related to GraphQL support on Dgraph. dgraph Issue or PR created by an internal Dgraph contributor. kind/feature Something completely new we should consider. Stale v21.12 supposedly corrected in v21.12

Comments

@rderbier
Copy link
Member

rderbier commented Dec 5, 2022 •
edited
Loading

What you wanted to do.

v21.12 PR : #7742
Discuss : https://discuss.dgraph.io/t/disallow-dql-schema-changes-for-predicates-used-in-graphql-schema/13570

If a predicate is being used in GraphQL it shouldn’t be modifiable via alter. It should only be changed in the GraphQL schema.

Why

improve GraphQL DQL interoperability.
Today can make changes to my DQL schema directly that would break my GraphQL schema.
@rderbier rderbier added kind/feature Something completely new we should consider. area/graphql Issues related to GraphQL support on Dgraph. dgraph Issue or PR created by an internal Dgraph contributor. v21.12 supposedly corrected in v21.12 labels Dec 5, 2022
@github-actions GitHub Actions
Copy link

This issue has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

@github-actions github-actions bot added the Stale label Jul 31, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph. dgraph Issue or PR created by an internal Dgraph contributor. kind/feature Something completely new we should consider. Stale v21.12 supposedly corrected in v21.12
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rderbier