fix(metrics): Expose dgraph_num_backups_failed_total metric view. #7900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been tracking this metric but didn't actually expose it in the metrics view, so Prometheus metrics in /metrics never showed it. This change updates sets the view properly so it shows up in /metrics.
danielmai
changed the title
ahsanbarkati
approved these changes
Jun 17, 2021
ahsanbarkati
pushed a commit
that referenced
this pull request
Jun 17, 2021
) We've been tracking this metric but didn't actually expose it in the metrics view, so Prometheus metrics in /metrics never showed it. This change updates sets the view properly so it shows up in /metrics. (cherry picked from commit 59fd122)
NamanJain8
pushed a commit
that referenced
this pull request
Jun 17, 2021
) (#7904) We've been tracking this metric but didn't actually expose it in the metrics view, so Prometheus metrics in /metrics never showed it. This change updates sets the view properly so it shows up in /metrics. (cherry picked from commit 59fd122) Co-authored-by: Daniel Mai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been tracking this metric but didn't actually expose it in the metrics
view, so Prometheus metrics in /metrics never showed it.
This change updates sets the view properly so it shows up in /metrics.
This change is