Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DQL): revert changes related to cascade pagination with sort (#7885) #7888

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

minhaj-shakeel
Copy link
Contributor

@minhaj-shakeel minhaj-shakeel commented Jun 4, 2021

Fixes DGRAPH-3370.
This PR reverts the change related to cascade with sort which is currently causing panic on the master.

(cherry picked from commit 5ae487f)


This change is Reviewable

Fixes DGRAPH-3370.
This PR reverts the change related to `cascade with sort` which is currently causing panic on the master.

(cherry picked from commit 5ae487f)
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @minhaj-shakeel)

@danielmai danielmai merged commit fa1ba2c into release/v21.03 Jun 4, 2021
@danielmai danielmai deleted the minhaj/cherry-pick1 branch June 4, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants