Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DQL): revert changes related to cascade pagination with sort #7885

Merged
merged 2 commits into from
Jun 4, 2021
Merged

fix(DQL): revert changes related to cascade pagination with sort #7885

merged 2 commits into from
Jun 4, 2021

Conversation

minhaj-shakeel
Copy link
Contributor

@minhaj-shakeel minhaj-shakeel commented Jun 4, 2021 •
edited
Loading

Fixes DGRAPH-3370.
This PR reverts the change related to cascade with sort which is currently causing panic on the master.

This change is Reviewable

vmrajas
vmrajas approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@vmrajas vmrajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minhaj-shakeel minhaj-shakeel merged commit 5ae487f into master Jun 4, 2021
@minhaj-shakeel minhaj-shakeel deleted the minhaj/cascade-sort-revert branch June 4, 2021 18:08
minhaj-shakeel added a commit that referenced this pull request Jun 4, 2021
@minhaj-shakeel
fix(DQL): revert changes related to cascade pagination with sort (#7885)
26a2bc2 
Fixes DGRAPH-3370.
This PR reverts the change related to `cascade with sort` which is currently causing panic on the master.

(cherry picked from commit 5ae487f)
minhaj-shakeel added a commit that referenced this pull request Jun 4, 2021
@minhaj-shakeel
fix(DQL): revert changes related to cascade pagination with sort (#7885)
7166efb 
Fixes DGRAPH-3370.
This PR reverts the change related to `cascade with sort` which is currently causing panic on the master.

(cherry picked from commit 5ae487f)
danielmai pushed a commit that referenced this pull request Jun 4, 2021
@minhaj-shakeel
fix(DQL): revert changes related to cascade pagination with sort (#7885…
fa1ba2c 
…) (#7888)

Fixes DGRAPH-3370.
This PR reverts the change related to `cascade with sort` which is currently causing panic on the master.

(cherry picked from commit 5ae487f)
danielmai pushed a commit that referenced this pull request Jun 4, 2021
@minhaj-shakeel
fix(DQL): revert changes related to cascade pagination with sort (#7885…
e3d3e62 
…) (#7889)

Fixes DGRAPH-3370.
This PR reverts the change related to `cascade with sort` which is currently causing panic on the master.

(cherry picked from commit 5ae487f)
@danielmai danielmai mentioned this pull request Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmrajas vmrajas vmrajas approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minhaj-shakeel @vmrajas