Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/21.03: make exports synchronous again #7877

Merged
merged 3 commits into from
Jun 3, 2021
Merged

release/21.03: make exports synchronous again #7877

merged 3 commits into from
Jun 3, 2021

Conversation

ajeetdsouza
Copy link
Contributor

@ajeetdsouza ajeetdsouza commented Jun 2, 2021 •
edited
Loading

21.03.0 has async backups, but not exports. An earlier cherry-pick moved the async backups onto the async Task framework, but also made exports async, which breaks backwards compatibility.

This PR is a temporary fix to make exports sync just for 21.03.1.

This change is Reviewable

@ajeetdsouza ajeetdsouza changed the base branch from master to release/v21.03 June 2, 2021 02:03
@github-actions github-actions bot added area/graphql Issues related to GraphQL support on Dgraph. area/testing Testing related issues labels Jun 2, 2021
@ajeetdsouza
Copy link
Contributor Author

CI has failed due to a bug on dgus-hotel. I've rerun CI here, and it has passed: https://teamcity.dgraph.io/buildConfiguration/Dgraph_Ci/139278

jarifibrahim
jarifibrahim approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please test it out locally once before merging.

dgraph/cmd/alpha/admin_backup.go Outdated Show resolved Hide resolved
@ajeetdsouza ajeetdsouza merged commit 8db52d2 into release/v21.03 Jun 3, 2021
@ajeetdsouza ajeetdsouza deleted the ajeet/export branch June 3, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsanbarkati ahsanbarkati ahsanbarkati left review comments

@jarifibrahim jarifibrahim jarifibrahim approved these changes

@danielmai danielmai Awaiting requested review from danielmai

@manishrjain manishrjain Awaiting requested review from manishrjain

@vvbalaji-dgraph vvbalaji-dgraph Awaiting requested review from vvbalaji-dgraph

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph. area/testing Testing related issues
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajeetdsouza @ahsanbarkati @jarifibrahim