bug fix to permit audit streaming to stdout writer #7803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsubaku9-pro
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
thsubaku9-pro
changed the title
aman-bansal
approved these changes
May 11, 2021
thsubaku9-pro
added a commit
that referenced
this pull request
May 11, 2021
thsubaku9-pro
added a commit
that referenced
this pull request
May 11, 2021
aman-bansal
pushed a commit
that referenced
this pull request
May 11, 2021
aman-bansal
pushed a commit
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code doesn't allow stdout (reserved keyword) to be used for audit streaming (since everything was being resolved as a path).
This PR first checks if the passed value is the same as stdout, if not it resolves it to a path
This change is