fix(GraphQL): fix @cascade with Pagination for @auth queries. #7695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhaj-shakeel
requested review from
manishrjain,
martinmr,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
abhimanyusinghgaur
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @manishrjain, @martinmr, @minhaj-shakeel, @pawanrawal, and @vvbalaji-dgraph)
graphql/resolve/query_rewriter.go, line 834 at r3 (raw file):
is applied
not required here.
Also, linter is complaining about 100 chars limit on line.
minhaj-shakeel
added a commit
that referenced
this pull request
Apr 9, 2021
Fixes GRAPHQL-1130. (cherry picked from commit 828e98a)
NamanJain8
pushed a commit
that referenced
this pull request
Apr 9, 2021
Fixes GRAPHQL-1130. (cherry picked from commit 828e98a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQL-1130.
This change is