[BREAKING] fix(commit): make txn context more robust #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
force-pushed
the
naman/txn-hash
branch
from
65d1881 to
d2e09c3
Compare
NamanJain8
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
changed the title
NamanJain8
force-pushed
the
naman/txn-hash
branch
3 times, most recently
from
766df2e to
245e829
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @manishrjain, @NamanJain8, and @vvbalaji-dgraph)
edgraph/server.go, line 1121 at r2 (raw file):
ctx = x.AttachJWTNamespace(ctx) if x.WorkerConfig.AclEnabled && req.GetStartTs() != 0 { // A fresh StartTs is assigned if it is 0.
Do we need this change?
NamanJain8
force-pushed
the
naman/txn-hash
branch
from
245e829 to
d545f5c
Compare
manishrjain
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Reviewed 1 of 7 files at r1, 5 of 6 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NamanJain8 and @vvbalaji-dgraph)
NamanJain8
added a commit
to dgraph-io/dgo
that referenced
this pull request
Apr 1, 2021
This PR adds the hash field in Request and TxnContext. These changes will be needed by hypermodeinc/dgraph#7659 which makes the transactions more robust.
aman-bansal
pushed a commit
that referenced
this pull request
Apr 8, 2021
Earlier, the transaction was identified by its startTs. It was expected from users to protect their transactions. With the introduction of multi-tenancy, this notion needs to change. As the startTs are shared by namespaces, we need to make sure that users from namespace ns1 can not operate upon transactions from namespace ns2 accidentally or maliciously. This PR makes the context of the transaction more robust by attaching some information for validation of claim over startTs. It is expected from user to send this special hash for commit/abort/mutate/query at that particular timestamp. Note that this change is breaking as the clients have to be modified to operate with Dgraph after this change. Additionally, this PR refactors the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, the transaction was identified by its
startTs. It was expected from users to protect their transactions. With the introduction of multi-tenancy, this notion needs to change. As the startTs are shared by namespaces, we need to make sure that users from namespacens1can not operate upon transactions from namespacens2accidentally or maliciously.This PR makes the context of the transaction more robust by attaching some information for validation of claim over
startTs. It is expected from user to send this specialhashfor commit/abort/mutate/query at that particular timestamp.Corresponding PR in dgo: dgraph-io/dgo#146
Note that this change is breaking as the clients have to be modified to operate with Dgraph after this change.
Additionally, this PR refactors the tests.
This change is