release/v20.11-slash: perf(compression): Use gzip with BestSpeed in export and backup #7643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The export and backup code were using BestCompression and Default gzip compression levels respectively. We see a 4x speed improvement when switch from BestCompression to BestSpeed compression level.
jarifibrahim
requested review from
danielmai,
manishrjain and
vvbalaji-dgraph
as code owners
jarifibrahim
changed the title
NamanJain8
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @danielmai, @manishrjain, and @vvbalaji-dgraph)
danielmai
pushed a commit
that referenced
this pull request
Mar 26, 2021
The export and backup code were using BestCompression and Default gzip compression levels respectively. We see a 4x speed improvement when switching from BestCompression to BestSpeed compression level.
jarifibrahim
pushed a commit
that referenced
this pull request
Apr 5, 2021
The export and backup code were using BestCompression and Default gzip compression levels respectively. We see a 4x speed improvement when switching from BestCompression to BestSpeed compression level. (cherry picked from commit 5676462)
jarifibrahim
pushed a commit
that referenced
this pull request
Apr 5, 2021
The export and backup code were using BestCompression and Default gzip compression levels respectively. We see a 4x speed improvement when switching from BestCompression to BestSpeed compression level. (cherry picked from commit 5676462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export and backup code were using BestCompression and Default
gzip compression levels respectively. We see a 4x speed improvement when
switch from BestCompression to BestSpeed compression level.
This change is