fix(GRAPHQL): fixed output coercing for admin fields. #7617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fixed test
github-actions
bot
added
the
area/graphql
JatinDev543
changed the title
abhimanyusinghgaur
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jatindevdg and @pawanrawal)
graphql/admin/admin.go, line 57 at r1 (raw file):
-(2^64)
0
UInt64 can't give -ve values.
graphql/schema/completion.go, line 432 at r1 (raw file):
return nil, valueCoercionError(v) } case "UInt64":
add a comment here that UInt64 is present only in admin schema.
and fixed comments
JatinDev543
commented
Mar 19, 2021
There was a problem hiding this comment.
Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @abhimanyusinghgaur and @pawanrawal)
graphql/admin/admin.go, line 57 at r1 (raw file):
Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…
-(2^64)
0
UInt64 can't give -ve values.
changed.
graphql/schema/completion.go, line 432 at r1 (raw file):
Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…
add a comment here that
UInt64is present only in admin schema.
added.
aman-bansal
pushed a commit
that referenced
this pull request
Mar 25, 2021
Fixes GRAPHQL-1100 We were getting output coercing error for fields like maxNodes in admin/state because internally that return value of type UInt64 but we were parsing it to Int. So we added UInt64 in GraphQL output types , Int64 in admin schema and changed the fields types accordingly in admin types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQL-1100
We were getting output coercing error for fields like
maxNodesinadmin/statebecause internally that return value of typeUInt64but we were parsing it toInt. So we addedUInt64in GraphQL output types ,Int64in admin schema and changed the fields types accordingly in admin types.This change is