Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GRAPHQL): Add error handling for unrecognized args to generate directive. #7612

Merged
merged 5 commits into from
Mar 23, 2021
Merged

fix(GRAPHQL): Add error handling for unrecognized args to generate directive. #7612

merged 5 commits into from
Mar 23, 2021

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Mar 18, 2021 •
edited
Loading

DGRAPH PR Message:

Motivation

  1. Added error handling in gqlparser (fix(Parser): Add directive argument validator dgraph-io/gqlparser#16) and bumped the version of gqlparser used in dgraph.
  2. Removed stray printing of typeName which was polluting the logs

This PR fixes: GRAPHQL 1076, 1122

Components affected by this PR

GQL Parser

Does this PR break backwards compatibility?

No

Fixes

This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Mar 18, 2021
vmrajas
vmrajas reviewed Mar 18, 2021
View reviewed changes
Copy link
Contributor

@vmrajas vmrajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a small error test in graphql/schema/gqlschema_test.yml ?

@all-seeing-code all-seeing-code force-pushed the anurags92/directiveBug branch from 664ab72 to 824efee Compare March 19, 2021 09:42
@all-seeing-code
Copy link
Contributor Author

Can you add a small error test in graphql/schema/gqlschema_test.yml ?

Made changes to the gqlparser and added the tests in that repo. Updated this PR to reflect only version change.

@all-seeing-code all-seeing-code merged commit 4755630 into release/v21.03 Mar 23, 2021
aman-bansal pushed a commit that referenced this pull request Mar 25, 2021
@all-seeing-code @aman-bansal
fix(GRAPHQL): Add error handling for unrecognized args to generate di…
cd796e4 
…rective. (#7612)
@joshua-goldstein joshua-goldstein deleted the anurags92/directiveBug branch August 11, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmrajas vmrajas vmrajas left review comments

@abhimanyusinghgaur abhimanyusinghgaur abhimanyusinghgaur approved these changes

@pawanrawal pawanrawal Awaiting requested review from pawanrawal

@manishrjain manishrjain Awaiting requested review from manishrjain

@vvbalaji-dgraph vvbalaji-dgraph Awaiting requested review from vvbalaji-dgraph

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@all-seeing-code @vmrajas @abhimanyusinghgaur