Fix(GraphQL): Add extra checks for deleting UpdateTypeInput #7595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A user had reported panic on schema update. The reason was that
cleanupInput
function cleared any input types which had name of the form,UpdateTInput
and contained exactly one field. This PR adds extra conditions to ensure that the input type is removed only when its generated by dgraph and contains a field by name,filter
.Testing:
Added unit test in graphql/schema/testdata/schemagen
Fixes GRAPHQL-1102
This change is