fix(persistent): make persistent query namespace aware #7570
Conversation
NamanJain8
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
changed the title
Can we add a test with and without relevant JWT token? |
There was a problem hiding this comment.
I am not familiar with this piece of code. @abhimanyusinghgaur can review this PR.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @manishrjain, @NamanJain8, and @vvbalaji-dgraph)
systest/multi-tenancy/basic_test.go, line 408 at r2 (raw file):
require.Zerof(t, len(resp.Errors), resp.Errors.Error())
you can use common.RequireNoGQLErrors(t, resp) for the same. That prints a better stack trace for debugging, if errors happen.
systest/multi-tenancy/basic_test.go, line 412 at r2 (raw file):
require.Zerof(t, len(resp.Errors), resp.Errors.Error())
common.RequireNoGQLErrors(t, resp)
Make persistent query namespace-aware. Also, there was a bug in a persistent query where an unauthorized user can add persistent queries.
This PR makes Persistent query namespace-aware. Also, there was a bug in a persistent query where an unauthorized user can add persistent queries.
This change is