Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): fix namespace parameter in export #7524

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Mar 8, 2021

This PR fixes the namespace parameter in export mutation.
Current behaviour:

  • Guardian of galaxy:
    If nothing is passed, exports Galaxy Namespace. If negative value is passed, exports all namespaces, else exports the specified namespace.
  • Guardian of other namespace(ns):
    If nothing is passed, exports ns. If a negative value is passed or the value passed nsPassed != ns, error is returned.

This change is Reviewable

@NamanJain8 NamanJain8 requested a review from pawanrawal as a code owner March 8, 2021 11:44
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Mar 8, 2021
@NamanJain8 NamanJain8 merged commit 98aaf00 into master Mar 8, 2021
@NamanJain8 NamanJain8 deleted the naman/export-parameter branch March 8, 2021 13:37
aman-bansal pushed a commit that referenced this pull request Mar 9, 2021
This PR fixes the namespace parameter in export mutation.
Guardian of galaxy:
If nothing is passed, exports Galaxy Namespace. If negative value is passed, exports all namespaces, else exports the specified namespace.
Guardian of another namespace (ns):
If nothing is passed, exports ns. If a negative value is passed or the value passed nsPassed != ns, error is returned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

2 participants