-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Consolidate multiple flags into a few SuperFlags #7436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 103 files reviewed, 11 unresolved discussions (waiting on @danielmai, @karlmcguire, @manishrjain, @martinmr, @pawanrawal, and @vvbalaji-dgraph)
dgraph/cmd/alpha/run.go, line 666 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
ideally, this can just be parsed in the right package instead of here.
Done.
dgraph/cmd/alpha/run.go, line 714 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Ideally, worker options only contains the SuperFlags, and lets the modules do what they need to with them.
Done.
dgraph/cmd/alpha/run.go, line 235 at r4 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
no need to use backticks if it fits in one line.
Done.
edgraph/server.go, line 1197 at r4 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Just ensure that we're not doing this parsing in the critical path.
Done.
(This is related to DGRAPH-3026.)
Al
Ze
Bu
Ba
Li
De
--badger
badger.compression
compression
goroutines
badger.cache_mb
cache-mb
badger.cache_percentage
cache-percentage
--acl
acl_secret_file
secret-file
acl_access_ttl
access-ttl
acl_refresh_ttl
refresh-ttl
--ludicrous
ludicrous_mode
enabled
ludicrous_concurrency
concurrency
--graphql
graphql_introspection
introspection
graphql_debug
debug
graphql_extensions
extensions
graphql_poll_interval
poll-interval
graphql_lambda_url
lambda-url
--raft
pending_proposals
pending-proposals
idx
idx
group
group
learner
learner
snapshot-after
snapshot-after
--security
auth_token
token
whitelist
whitelist
--limit
query_edge_limit
query-edge
normalize_node_limit
normalize-node
mutations_nquad_limit
mutations-nquad
--tls
tls_cacert
cacert
tls_use_system_ca
use-system-ca
tls_server_name
server-name
tls_client_auth
client-auth
tls_node_cert
node-cert
tls_node_key
node-key
tls_internal_port_enabled
internal-port-enabled
tls_cert
cert
tls_key
key
--trace
trace
ratio
jaeger.collector
jaeger
datadog.collector
datadog
--vault
vault_addr
addr
vault_roleid_file
role-id-file
vault_secretid_file
secret-id-file
vault_path
path
vault_field
field
vault_format
format
Example
Previously you could use ACL flags like this:
After this PR:
This change is