perf(backups): Reduce latency of list backups #7435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list backups function was reading manifest files sequentially and this is expensive. This PR improves the latency by parallelizing the list backup calls.
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
aman-bansal
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list backups function was reading manifest files sequentially and
this is expensive. This PR improves the latency by parallelizing the
list backup calls.
For 10 backups stored in a single s3 bucket, list backups takes 31 seconds on master
On this PR, it takes ~4.5 seconds
This change is