fix(GraphQL): fix @auth rules evaluation in case of null variables in custom claims. #7380
Conversation
github-actions
bot
added
the
area/graphql
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @minhaj-shakeel)
graphql/e2e/auth/auth_test.go, line 498 at r1 (raw file):
} func TestAuthRulesWithNullValuesInJWT(t *testing.T) {
add a case for deep value as well
graphql/resolve/auth_query_test.yaml, line 1078 at r1 (raw file):
queryUser { username tickets {
Tickets should not be returned if auth rule is negative here because of null USER value?
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @pawanrawal)
graphql/e2e/auth/auth_test.go, line 498 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
add a case for deep value as well
Done.
graphql/resolve/auth_query_test.yaml, line 1078 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
Tickets should not be returned if auth rule is negative here because of null USER value?
Tickets are not being returned as expected. The given query will only return username and an empty array for tickets.
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @minhaj-shakeel)
Fixes GRAPHQL-988.
This change is