[BREAKING] feat(Dgraph): Read-Only replicas #7272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
commented
Jan 18, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @martinmr and @vvbalaji-dgraph)
dgraph/cmd/zero/zero.go, line 539 at r1 (raw file):
return proposal } // TODO: Allow each Alpha to specify which group it should be part of.
remove this.
jarifibrahim
approved these changes
Jan 18, 2021
|
✔️ Deploy preview for dgraph-docs ready! 🔨 Explore the source changes: 5472d86 🔍 Inspect the deploy logs: https://app.netlify.com/sites/dgraph-docs/deploys/6005fca1495dfb00077eae90 😎 Browse the preview: https://deploy-preview-7272--dgraph-docs.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a Dgraph Alpha or Zero instance to join as a "learner" node. That allows a user to spin up a replica instance across the world, without paying for the cost of latency. This replica can be used to serve best-effort queries really fast. It can also do both reads and writes, but would incur the latency of the network calls to the main cluster.
The main code change is small. But, due to the flag changes, this PR touches lots of config files.
Breaking: The breaking change here is how we pass in Raft flags. Before this PR, we used to have
--idxflag. That flag is now gone. Both Alpha and Zero now use a "raft" flag, which takesidx=N; group=M; learner=truestring based options.This change is